Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module-info to jca #21426

Merged
merged 12 commits into from
May 21, 2021
Merged

add module-info to jca #21426

merged 12 commits into from
May 21, 2021

Conversation

michaelqi793
Copy link
Contributor

No description provided.

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels May 14, 2021
@chenrujun chenrujun self-assigned this May 18, 2021
@chenrujun chenrujun added the azure-spring-keyvault Spring keyvault related issues. label May 18, 2021
@chenrujun chenrujun added this to the [2021] June milestone May 18, 2021
@chenrujun chenrujun linked an issue May 18, 2021 that may be closed by this pull request
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
Copy link

Hi, @michaelqi793 , could you please investigate the pipeline failure?

@chenrujun
Copy link

I created an issue about keyvault-ci pipeline failure: #21677

Let's wait.

@chenrujun
Copy link

Hi, @michaelqi793 ,
This PR #21703 is merged, please merge latest master branch to your branch.

@chenrujun chenrujun merged commit d5995f9 into Azure:master May 21, 2021
@michaelqi793 michaelqi793 deleted the use_moditect branch May 28, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add module-info.java to azure-security-keyvault-jca
2 participants