-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add module-info to jca #21426
Merged
Merged
add module-info to jca #21426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelqi793
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
May 14, 2021 05:38
michaelqi793
requested review from
alzimmermsft,
danieljurek,
g2vinay,
JimSuplizio,
mitchdenny and
samvaity
as code owners
May 17, 2021 09:11
chenrujun
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi, @michaelqi793 , could you please investigate the pipeline failure? |
I created an issue about Let's wait. |
Hi, @michaelqi793 , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
azure-spring
All azure-spring related issues
azure-spring-keyvault
Spring keyvault related issues.
KeyVault
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.