ADT: Bug fix: serialization issue with strings which starts with a numeric value. #21623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azabbasi
requested review from
abhipsaMisra,
barustum,
bikamani,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
ghost
added
the
timtay-microsoft
approved these changes
May 18, 2021
...java/com/azure/digitaltwins/core/implementation/serializer/DigitalTwinsStringSerializer.java
Show resolved
Hide resolved
drwill-ms
reviewed
May 18, 2021
drwill-ms
reviewed
May 18, 2021
...java/com/azure/digitaltwins/core/implementation/serializer/DigitalTwinsStringSerializer.java
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
May 18, 2021
...ltwins/azure-digitaltwins-core/src/test/java/com/azure/digitaltwins/core/TwinAsyncTests.java
Show resolved
Hide resolved
drwill-ms
reviewed
May 18, 2021
...java/com/azure/digitaltwins/core/implementation/serializer/DigitalTwinsStringSerializer.java
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
May 18, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Nov 22, 2022
{containerregistry} Fix Azure#21603: Mention anonymous pull access is a preview feature, available in the Standard and Premium service tiers (Azure#21623)
Fixes Azure/azure-rest-api-specs#21603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom serialization layer which makes sure that a string is a Json payload and based on that logic writes the value into the json generator.
The logic where we decide whether or not a string value is a valid json, automatically decides that a string value that starts with a number is a valid json payload and writes the value which is a number to the json generator.
By making sure that either the input string is a container node or is a simple text, we can avoid this issue.