Additional HttpClientOptions Configurations #22248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
hemanttanwar,
jianghaolu,
lmolkova and
srnagar
as code owners
srnagar
reviewed
Jun 11, 2021
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Show resolved
Hide resolved
| @@ -26,6 +29,15 @@ public HttpClient createInstance(HttpClientOptions clientOptions) { | |||
| .configuration(clientOptions.getConfiguration()) | |||
| .writeTimeout(clientOptions.getWriteTimeout()) | |||
| .readTimeout(clientOptions.getReadTimeout()); | |||
|
|
|||
| int maximumConnectionPoolSize = (clientOptions.getMaximumConnectionPoolSize() == 0) | |||
| ? 5 // By default OkHttp uses a maximum idle connection count of 5. | |||
There was a problem hiding this comment.
I think we should not set anything if the user has not configured the pool size. This number could change with later releases of OkHttp.
There was a problem hiding this comment.
It is a required parameter in the constructor, I'll check if they (OkHttp) have it as a constant anywhere.
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Jun 11, 2021
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Jun 15, 2021
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21193
This PR adds additional configuration options to
HttpClientOptionsallowing for easier configuration of anHttpClientimplementation's connection management.