-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] SAS version cleanup. #22255
[Storage] SAS version cleanup. #22255
Conversation
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
1 similar comment
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
...e-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/BlobSasImplUtil.java
Show resolved
Hide resolved
@@ -702,7 +701,7 @@ private String stringToSign(String canonicalName) { | |||
this.identifier == null ? "" : this.identifier, | |||
this.sasIpRange == null ? "" : this.sasIpRange.toString(), | |||
this.protocol == null ? "" : this.protocol.toString(), | |||
version, /* Pin down to version so old string to sign works. This is reflected in the declaration of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hardcode this? This is all called from deprecated code and I feel like this will break as the string to sign changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. Currently this code doesn't work... that string to sign (or the other one below/above) hasn't been changed as service version evolved
Just had one comment about hardcoding the version that we should apply to all XXXServiceSasSignatureValues stringToSign methods |
@gapra-msft Blobs is the only place it seems to matter for now. We don't branch out this logic elsewhere (datalake doesn't even have equivalent). |
@kasobol-msft Even if it doesn't matter for now, shouldn't we future proof it? |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
TargetExtendedLocations should accept StandardSSD_LRS as a valid storage account type (Azure#22255)
No description provided.