Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] SAS version cleanup. #22255

Merged
merged 13 commits into from
Jun 15, 2021

Conversation

kasobol-msft
Copy link
Contributor

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 11, 2021
@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

1 similar comment
@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft kasobol-msft marked this pull request as ready for review June 15, 2021 16:08
@@ -702,7 +701,7 @@ private String stringToSign(String canonicalName) {
this.identifier == null ? "" : this.identifier,
this.sasIpRange == null ? "" : this.sasIpRange.toString(),
this.protocol == null ? "" : this.protocol.toString(),
version, /* Pin down to version so old string to sign works. This is reflected in the declaration of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hardcode this? This is all called from deprecated code and I feel like this will break as the string to sign changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Currently this code doesn't work... that string to sign (or the other one below/above) hasn't been changed as service version evolved

@gapra-msft
Copy link
Member

Just had one comment about hardcoding the version that we should apply to all XXXServiceSasSignatureValues stringToSign methods

@kasobol-msft
Copy link
Contributor Author

ServiceSasSignatureValues

@gapra-msft Blobs is the only place it seems to matter for now. We don't branch out this logic elsewhere (datalake doesn't even have equivalent).

@gapra-msft
Copy link
Member

@kasobol-msft Even if it doesn't matter for now, shouldn't we future proof it?

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft kasobol-msft merged commit 8f341f2 into Azure:master Jun 15, 2021
@kasobol-msft kasobol-msft deleted the configurable-sas-version branch June 15, 2021 21:48
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 2, 2023
TargetExtendedLocations should accept StandardSSD_LRS as a valid storage account type (Azure#22255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants