-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gated test for client telemetry service validation #22300
Adding gated test for client telemetry service validation #22300
Conversation
sdk/cosmos/tests.yml
Outdated
@@ -3,7 +3,7 @@ trigger: none | |||
variables: | |||
- template: ../../eng/pipelines/templates/variables/globals.yml | |||
- name: AdditionalArgs | |||
value: '' | |||
value: '-DCOSMOS.CLIENT_TELEMETRY_ENDPOINT=$(cosmos-client-telemetry-endpoint)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbp as discussed added the environment variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/check-enforcer override |
This PR contains
Adding gated test for client telemetry service validation
(Juno stage endpoint will be available via environment variable added in tests.yml as cosmos-client-telemetry-endpoint
whose value is coming from our TestSecrets-Cosmos key vault)
Adding our default httptimeout for client telemetry request
refactored the package to remove camel case from package name com.azure.cosmos.implementation.clientTelemetry -> com.azure.cosmos.implementation.clienttelemetry.