Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify spring configurations #22396

Closed
wants to merge 36 commits into from
Closed

Unify spring configurations #22396

wants to merge 36 commits into from

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Jun 20, 2021 •
edited
Loading

Provide common azure sdk configurations from com.azure.core.util.Configuration in AzureProperties in azure-spring-boot-core. Customers can use those with spring.cloud.azure.*** to configure common properites.

This pr refactors #21613

@ghost ghost added the azure-spring All azure-spring related issues label Jun 20, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 20, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo force-pushed the unify-spring-configurations branch from f74c2f3 to 7d2dc74 Compare June 20, 2021 14:10
@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 20, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo marked this pull request as ready for review June 21, 2021 02:20
@yiliuTo yiliuTo force-pushed the unify-spring-configurations branch from 07a4d84 to b1f3e81 Compare July 10, 2021 09:03
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 10, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo force-pushed the unify-spring-configurations branch from b1f3e81 to a946835 Compare July 10, 2021 10:20
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 10, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo force-pushed the unify-spring-configurations branch from a946835 to dadee07 Compare July 10, 2021 11:16
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 10, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 12, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 12, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 12, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo force-pushed the unify-spring-configurations branch from 0e450e3 to de6501c Compare July 13, 2021 01:49
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 13, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna saragluna self-assigned this Jul 13, 2021
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 13, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo mentioned this pull request Jul 13, 2021
Merged
@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 13, 2021

Close this pr for #22937 merges it in a feature branch

@yiliuTo yiliuTo closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun requested changes

@backwind1233 backwind1233 backwind1233 left review comments

@stliu stliu stliu left review comments

@saragluna saragluna saragluna approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@danieljurek danieljurek Awaiting requested review from danieljurek

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@samvaity samvaity Awaiting requested review from samvaity

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

Assignees

@saragluna saragluna

@yiliuTo yiliuTo

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] August
Development

Successfully merging this pull request may close these issues.
5 participants
@yiliuTo @stliu @backwind1233 @chenrujun @saragluna