Enable transport type in service properties #22604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhichengliu12581
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
the
|
I don't think this is the only missing config property, probably we should add all the missing config here? |
…to enable-transport-type-in-service-properties
…to finish all properties
|
@stliu In order not to block the current issue, I revert the code related to other properties. I will create other tasks to support the properties in the SDK. |
yiliuTo
reviewed
Jun 29, 2021
...ava/com/azure/spring/integration/servicebus/factory/DefaultServiceBusTopicClientFactory.java
Outdated
Show resolved
Hide resolved
...ava/com/azure/spring/integration/servicebus/factory/DefaultServiceBusQueueClientFactory.java
Show resolved
Hide resolved
...src/main/java/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusProperties.java
Outdated
Show resolved
Hide resolved
| @@ -87,6 +89,14 @@ public void testConnectionStringProvided() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testTransportTypeWithAmqpWebSockets() { | |||
| this.contextRunner.withPropertyValues(SERVICE_BUS_PROPERTY_PREFIX + "transport-type=AmqpWebSockets") | |||
There was a problem hiding this comment.
the tested value need to be updated as well.
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
This was referenced Jul 1, 2021
Closed
zhichengliu12581
deleted the
enable-transport-type-in-service-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate issue: #22445