Refactor Azure Spring projects structure #23004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-spring-boot to azure-spring-cloud-autoconfigure, delete azure-spring-cloud-storage and move resource managers out of azure-spring-cloud-context
saragluna
requested review from
alzimmermsft,
backwind1233,
benbp,
chenrujun,
danieljurek,
g2vinay,
JimSuplizio,
JonathanGiles,
mssfang,
samvaity,
srnagar,
stliu and
yiliuTo
as code owners
ghost
added
the
This comment has been minimized.
This comment has been minimized.
|
/azp run java - spring - tests |
|
/azp run java - spring - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yiliuTo
reviewed
Jul 19, 2021
| import com.azure.spring.cloud.autoconfigure.context.AzureContextProperties; | ||
| import com.azure.spring.cloud.context.core.api.EnvironmentProvider; | ||
| import com.azure.spring.cloud.autoconfigure.context.AzureResourceManagerAutoConfiguration; | ||
| import com.azure.spring.cloud.context.core.api.AzureResourceMetadata; | ||
| import com.azure.spring.cloud.context.core.impl.EventHubNamespaceManager; | ||
| import com.azure.spring.cloud.context.core.impl.StorageAccountManager; | ||
| import com.azure.spring.cloud.context.core.storage.StorageConnectionStringProvider; |
There was a problem hiding this comment.
StorageConnectionStringProvider class could be moved to package com.azure.spring.cloud.autoconfigure.storage of lib azure-spring-cloud-autoconfigure as well.
|
Will create another PR to address:
|
yiliuTo
reviewed
Jul 19, 2021
|
|
||
| private String region; | ||
| private String resourceGroup; | ||
| private boolean autoCreateResources; |
There was a problem hiding this comment.
The property of tetantId and subscriptionId could be put here as well.
saragluna
added a commit
to saragluna/azure-sdk-for-java
that referenced
this pull request
Aug 16, 2021
saragluna
added a commit
that referenced
this pull request
Aug 17, 2021
…23597) * Unify spring configurations (#22937) * Refactor Azure Spring projects structure (#23004) * Mapping spring legacy props (#23166) ** use file for property mapping ** add environmentpostprocessor after kv ** map multiple key vault use case * update readme for unified configuration (#23452) Co-authored-by: Yi Liu <yiliu6@microsoft.com>
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring the Azure Spring project structures.
Remove azure-spring-boot (the autoconfiguration module), move the code to azure-spring-cloud-autoconfigure
Remove azure-spring-boot-core, move the code to azure-spring-cloud-context
Make a separate module azure-spring-cloud-resourcemanager