Fix Flaky Core Tests #23600
Merged
Fix Flaky Core Tests #23600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
jianghaolu,
lmolkova,
mssfang,
pallavit,
srnagar and
vcolin7
as code owners
srnagar
approved these changes
Aug 16, 2021
sdk/core/azure-core/src/test/java/com/azure/core/credential/TokenCacheTests.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Aug 16, 2021
srnagar
reviewed
Aug 16, 2021
Comment on lines
+47
to
+48
| // Ensure that only one refresh attempt is made. | ||
| assertEquals(1, refreshes.get()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes flaky tests in
azure-core. They fall under the following categories:Usage of global resources which introduced race conditions.
Isolationannotation which runs the annotated test class in a thread safe fashion. Additionally, these test classes were also annotation withExecution(ExecutionMode.SAME_THREAD)to run the tests contained in the class sequentially.Replaced usage of
publishOn(Schedulers.parallel())toparallel().runOn(Schedulers.parallel())to better ensure parallel execution of logic.