Address UX study feedback and API review feedback #23799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
requested review from
anuchandy,
conniey,
jianghaolu,
JonathanGiles,
joshfree,
lmolkova,
mssfang and
pallavit
as code owners
pallavit
reviewed
Aug 30, 2021
pallavit
reviewed
Aug 30, 2021
| field.setAccessible(false); | ||
| } catch (IllegalAccessException ex) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("Failed to set column value for " + columnName, ex)); |
There was a problem hiding this comment.
Why allow partial creation of the object?
There was a problem hiding this comment.
This won't create partial objects. If we fail to set the value of any column, this whole method will throw. So, the caller of this method will not get any result.
pallavit
reviewed
Aug 30, 2021
...-query/src/main/java/com/azure/monitor/query/implementation/logs/models/LogsQueryHelper.java
Show resolved
Hide resolved
pallavit
reviewed
Aug 30, 2021
sdk/monitor/azure-monitor-query/src/main/java/com/azure/monitor/query/LogsQueryAsyncClient.java
Show resolved
Hide resolved
pallavit
reviewed
Aug 30, 2021
...nitor/azure-monitor-query/src/main/java/com/azure/monitor/query/MetricsQueryAsyncClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the feedback that we received during the user studies and also includes changes that were recommended during the API review.