Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky Key Vault live tests. #24606

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Conversation

vcolin7
Copy link
Member

@vcolin7 vcolin7 commented Oct 7, 2021

Fixes a couple tests that sometimes fail in pipeline runs such as this one. We now use the result of a create operation to run an update operation instead of adding a bunch of get calls in the middle.

Also removed a couple tests that shouldn't be ran against Azure Key Vault, but Managed HSM only.

…st` and `KeyAsyncClientTest`, as setting a public exponent is currently only available for Managed HSM.
…st`'s `updateKey()` and `updateDisabledKey()` to avoid calling `getKey()` before the service has had a chance to update a given key.
@vcolin7 vcolin7 requested a review from g2vinay as a code owner October 7, 2021 03:06
@vcolin7 vcolin7 self-assigned this Oct 7, 2021
@ghost ghost added the KeyVault label Oct 7, 2021
@vcolin7 vcolin7 merged commit f7c35ca into Azure:main Oct 7, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Nov 10, 2023
Release web 2023 01 01 (Azure#26545)

* Add new api-version 2023-01-01 (Azure#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (Azure#23084)

* Fix OneDeploy request and response bodies (Azure#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (Azure#24102)

Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>

* Add minTlsCipherSuite property (Azure#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>

* Dapr configuration for a site (Azure#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>

* Fix for JS SDK check failure for Dapr Config (Azure#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>

* Release web 2023 01 01 (Azure#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>

* Release web 2023 01 01 (Azure#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>

* Adding workload profile & resource config to Site (Azure#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (Azure#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (Azure#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (Azure#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (Azure#23224)" (Azure#26580)

This reverts commit 7dfc303ee18440ee5eede155bb0d63797fbdc4bb.

---------

Co-authored-by: Alex Karcher <alkarche@microsoft.com>
Co-authored-by: dannysongg <38927254+dannysongg@users.noreply.github.com>
Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com>
Co-authored-by: Vishal Gupta <vishgupta@microsoft.com>
Co-authored-by: Chris Rosenblatt <rosench13@gmail.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: SushmithaVReddy <sushmithavangala@gmail.com>
Co-authored-by: Sushmitha Vangala <svangala@microsoft.com>
Co-authored-by: rohinisharma <rohini2@illinois.edu>
Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>
Co-authored-by: mukundnigam <34106498+mukundnigam@users.noreply.github.com>
Co-authored-by: Kirstyn Amperiadis <102087132+kamperiadis@users.noreply.github.com>
Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants