Rename to SchemaRegistryApacheAvroSerializer. Group name is optional. #24622
Conversation
conniey
changed the title
|
API changes have been detected in |
|
API changes have been detected in |
| * @param maxCacheSize The maximum cache size for the serializer. | ||
| */ | ||
| SerializerOptions(String schemaGroup, boolean autoRegisterSchemas, int maxCacheSize) { | ||
| this.schemaGroup = schemaGroup; |
There was a problem hiding this comment.
Can this be null? Previously, this was a required field and we had a null check in the serializer constructor. If this can't be null, let's add a null check here.
There was a problem hiding this comment.
It can be null now. From the arch board review, if you're only using it for deserialization, the stream contains the ID which is globally unique, so you can just get by an id without the schema group.
...-schemaregistry-avro/src/main/java/com/azure/data/schemaregistry/avro/SerializerOptions.java
Outdated
Show resolved
Hide resolved
| @@ -26,26 +26,31 @@ | |||
| /** | |||
| * Schema Registry-based serializer implementation for Avro data format. | |||
There was a problem hiding this comment.
Update the javadoc as well to specify that this is Apache Avro data format.
| * | ||
| * @return The maximum cache size. | ||
| */ | ||
| int getMaxCacheSize() { |
There was a problem hiding this comment.
Should this be long? I don't expect the cache size to be beyond max int but do we want to have the flexibility?
There was a problem hiding this comment.
For GA, we are not exposing this max cache size to be configurable; so in November, it'll just be 128. It won't be a breaking change if we decide after GA to expose the cache options.
| } else if (Objects.isNull(context)) { | ||
| return FluxUtil.monoError(logger, new NullPointerException("'context' should not be null.")); | ||
| } |
There was a problem hiding this comment.
Context can be null and if it is, we should use Context.NONE and not throw.
…a/com/azure/data/schemaregistry/avro/SerializerOptions.java Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com>
schemaFormat->formatto align with other languages.Related #24221