Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the nativeHeader conversion logic #24669

Merged

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Oct 8, 2021

Fixes #24649
The com.azure.spring:azure-spring-cloud-stream-binder-eventhubs:latest can work with spring-cloud-starter-sleuth:3.0.3, no UnsupportedOperationException or ClassCastException exceptions. The header nativeHeader of the message can be converted to a JSON value. The tracing of the Azure AMQP based service will be tracked in this issue #24652.

@moarychan moarychan added azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. labels Oct 8, 2021
@moarychan
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moarychan moarychan merged commit d37ed4c into Azure:main Oct 12, 2021
@moarychan moarychan deleted the fix/the-wrong-nativeHeaders-conversion branch November 17, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UnsupportedOperationException when building nativeHeaders
2 participants