Fix Spring Cloud Azure 4.0 EventHubs binder processor configuration #24888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
michaelqi793,
moarychan,
stliu,
yiliuTo,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
ghost
added
the
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stliu
reviewed
Oct 20, 2021
| .build() | ||
| .buildAsyncClient() | ||
| .getBlobContainerAsyncClient(checkpointStoreProperties.getContainerName()); | ||
|
|
||
| if (Boolean.FALSE.equals(blobContainerAsyncClient.exists().block(Duration.ofSeconds(3)))) { |
There was a problem hiding this comment.
and this has to be done at the initializing time in a sync way?
since this will slow up the spring boot application start up time and it is already pretty slow
There was a problem hiding this comment.
should we add two more configuration entries here, to let users customize whether to create the container automatically and the timeout.
…uring the initialization of blob container
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stliu
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AzureBlobCheckpointStoreConfigurationwas only conditional on propertycontainer-name, but we needaccount-name+container-nametogether to locate a blob container. So in this PR theAzureBlobCheckpointStoreConfigurationwill be conditional on these two properties.In the early version, a
BlobServiceClientBuilderFactorywas created inside the creation of beanBlobCheckpointStore, which will make theBlobServiceClientBuilderFactoryinaccessible for some instrumentation. So in this PR, a bean ofBlobServiceClientBuilderFactorywill be created.Also added some tests for the
BlobServiceClientBuilderFactoryand to make sure it could work withAzureStorageBlobAutoConfiguration.Also remove the
optionalscope for<artifactId>azure-messaging-eventhubs-checkpointstore-blob</artifactId>inspring-cloud-azure-stream-binder-eventhubs.