-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource manager packages compatible with the 2020-09-01-hybrid profile API versions #25103
Add resource manager packages compatible with the 2020-09-01-hybrid profile API versions #25103
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
Thanks @bbridges for the extra effort on making cleaner commits here! @weidongxu-microsoft could you please review the commits and help with build changes? We really appreciate your help and support here |
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
I've build it locally, code seems good. Engineering part, one thing that need to be solved is the versioning integration at https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt#L198 Please locally run "mvn checkstyle:check" and "mvn spotbugs:check" to solve the error if possible. You seems not using Java11+ for code generation, hence the auto-formatter does not take effect. You might had to re-generate these RPs. |
/azp run java - resourcemanagerhybrid - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
version check script is still checking on how this works. |
API changes have been detected in |
API changes have been detected in API changes - public String identifier()
- @Override public String toString()
+ public String identifier()
+ @Override public String toString() |
Partial revert of "Mgmt: Graph, update to microsoft graph API (Azure#18420)" This reverts commit 8614521.
ade87b0
to
f506239
Compare
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - resourcemanagerhybrid - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Wes OKed with the changes on the CI (add a PreBuildSteps, and exclude |
This PR adds new Track 2 resource manager packages which were copied and regenerated in order to be compatible with API versions in the 2020-09-01-hybrid profile. Minimal changes were made against the packages to get this to work against these API versions, and resource types which are found in the resource manager packages but not in the hybrid profile were kept to reduce the amount of required changes. These new modules were placed in a new
/sdk/resourcemanagerhybrid/
folder.The group ID / artifact ID of these modules are the same as the existing Track 2 packages, and to reduce conflicts, they are not included in the root POM file. Instead, the versions are suffixed with
-hybrid
to tell them apart.