Add @ConditionalOnBean on CosmosReactiveRepositoriesAutoConfiguration #25237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epositories` 2. add @ConditionalOnProperty
backwind1233
requested review from
chenrujun,
moarychan,
saragluna,
stliu,
yiliuTo and
zhichengliu12581
as code owners
ghost
added
the
3 tasks
saragluna
requested changes
Nov 9, 2021
...zure/spring/cloud/autoconfigure/data/cosmos/CosmosReactiveRepositoriesAutoConfiguration.java
Show resolved
Hide resolved
...va/com/azure/spring/cloud/autoconfigure/data/cosmos/CosmosRepositoriesAutoConfiguration.java
Show resolved
Hide resolved
|
@saragluna Do you still have any concern about this PR？ |
|
@backwind1233 one more thing, we should make sure all integration tests pass for such changes. |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
reviewed
Nov 15, 2021
...zure/spring/cloud/autoconfigure/data/cosmos/CosmosReactiveRepositoriesAutoConfiguration.java
Outdated
Show resolved
Hide resolved
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure.cosmos.repositoriestospring.cloud.azure.cosmos.repositories