Spring cloud azure refactor global properties #25239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/amqp properties globally
saragluna
requested review from
backwind1233,
chenrujun,
JonathanGiles,
moarychan,
mssfang,
stliu,
yiliuTo and
zhichengliu12581
as code owners
ghost
added
the
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API changes have been detected in |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stliu
reviewed
Nov 9, 2021
...ure/spring/cloud/autoconfigure/context/AzureGlobalConfigurationEnvironmentPostProcessor.java
Outdated
Show resolved
Hide resolved
stliu
approved these changes
Nov 9, 2021
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ng-cloud-azure-refactor-global-properties
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ng-cloud-azure-refactor-global-properties
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@stliu please take a look at the last commit, it fixed a bug in AzureProfile.Environment. I assume when using a known azure environment, it should not allow modification. |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stliu
approved these changes
Nov 10, 2021
This comment has been minimized.
This comment has been minimized.
…ng-cloud-azure-refactor-global-properties
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ng-cloud-azure-refactor-global-properties
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
deleted the
xiada/feature/spring-cloud-azure-refactor-global-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the AzureGlobalProperties to allow configuring http/amqp related properties in the uppermost level.