Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CHANGELOGs and READMEs ahead of the Key Vault beta release for November 2021. #25365

Merged

Conversation

vcolin7
Copy link
Member

@vcolin7 vcolin7 commented Nov 12, 2021

No description provided.

@vcolin7 vcolin7 requested a review from g2vinay November 12, 2021 11:33
@vcolin7 vcolin7 self-assigned this Nov 12, 2021
@vcolin7 vcolin7 requested a review from samvaity as a code owner November 12, 2021 11:33
@ghost ghost added the KeyVault label Nov 12, 2021
@vcolin7 vcolin7 requested a review from srnagar November 12, 2021 20:57
@vcolin7
Copy link
Member Author

vcolin7 commented Nov 12, 2021

/check-enforcer override

@vcolin7
Copy link
Member Author

vcolin7 commented Nov 12, 2021

Overrode Check Enforcer as it incorrectly flagged an issue related to the eng/common folder.

@@ -16,7 +16,7 @@ Maven dependency for the Azure Key Vault Secrets client library. Add it to your
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.3.4</version>
<version>4.4.0-beta.3</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README versions should point to stable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ones that will be included with a beta release's tag should point to the beta version, after releasing said version I'll update the READMEs to point to stable.

@@ -14,7 +14,7 @@ Maven dependency for the Azure Key Vault Administration library. Add it to your
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-administration</artifactId>
<version>4.0.4</version>
<version>4.1.0-beta.3</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README version should point to stable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ones that will be included with a beta release's tag should point to the beta version, after releasing said version I'll update the READMEs to point to stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@vcolin7
Copy link
Member Author

vcolin7 commented Nov 15, 2021

/check-enforcer override

@vcolin7 vcolin7 merged commit 6187421 into Azure:main Nov 15, 2021
XiaofeiCao pushed a commit to XiaofeiCao/azure-sdk-for-java that referenced this pull request Nov 18, 2021
…r November 2021. (Azure#25365)

* Updated CHANGELOG and README.

* Removed unused imports.
@vcolin7 vcolin7 deleted the prepare-key-vault-beta-release-november-2021 branch January 13, 2022 04:47
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Sep 29, 2023
Dev/kalyanke/webhook activitypolicy (Azure#25365)

* Add pipeline policy and ElapsedTime Policy

* adding missing objects

* fix schema validation

* fix prettier issues

* Change webhook to ExecutionActivity

* change to policy object

* fix comments

---------

Co-authored-by: Kalyan C Kesireddy <kalyanke@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants