Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Usage of Embedme in Core Libraries #25377

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Remove Usage of Embedme in Core Libraries #25377

merged 1 commit into from
Nov 15, 2021

Conversation

alzimmermsft
Copy link
Member

Description

This PR removes the usage of embedme for injecting codesnippets into READMEs in the Core libraries.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Nov 12, 2021
@alzimmermsft alzimmermsft self-assigned this Nov 12, 2021
@alzimmermsft alzimmermsft merged commit 8b3fa1a into Azure:main Nov 15, 2021
@alzimmermsft alzimmermsft deleted the AzCore_RemoveUsageOfEmbedme branch November 15, 2021 17:00
XiaofeiCao pushed a commit to XiaofeiCao/azure-sdk-for-java that referenced this pull request Nov 18, 2021
@alzimmermsft @XiaofeiCao
Remove Usage of Embedme in Core Libraries (Azure#25377)
5d00aa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@pallavit pallavit Awaiting requested review from pallavit

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @JonathanGiles @srnagar