mgmt, support getNetworkInterfaceAsync #25400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
added
Mgmt
weidongxu-microsoft
requested review from
ArthurMa1978,
haolingdong-msft and
XiaofeiCao
as code owners
...c/main/java/com/azure/resourcemanager/compute/implementation/VirtualMachineScaleSetImpl.java
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Nov 16, 2021
…uire connect to VM
Comment on lines
-294
to
+296
| // Assert public load balancing connection | ||
| if (!isPlaybackMode()) { | ||
| HttpClient client = new NettyAsyncHttpClientBuilder().build(); | ||
| HttpRequest request = new HttpRequest(HttpMethod.GET, "http://" + fqdn); | ||
| HttpResponse response = client.send(request).block(); | ||
| Assertions.assertEquals(response.getStatusCode(), 200); | ||
| } | ||
| Assertions.assertNotNull(fqdn); | ||
| // // Assert public load balancing connection | ||
| // if (!isPlaybackMode()) { | ||
| // HttpClient client = HttpClient.createDefault(); | ||
| // HttpRequest request = new HttpRequest(HttpMethod.GET, "http://" + fqdn); | ||
| // HttpResponse response = client.send(request).block(); | ||
| // Assertions.assertEquals(response.getStatusCode(), 200); | ||
| // } |
There was a problem hiding this comment.
Remove due to these no longer work (could be caused by security policy).
Comment on lines
+1372
to
+1374
| String nicIdB = vm.getNetworkInterfaceAsync(nic.name()).map(n -> nic.primaryIPConfiguration().networkId()).block(); | ||
| Assertions.assertNotNull(nicB); | ||
| Assertions.assertNotNull(nicIdB); |
There was a problem hiding this comment.
Added one line test.
XiaofeiCao
pushed a commit
to XiaofeiCao/azure-sdk-for-java
that referenced
this pull request
Nov 18, 2021
* mgmt, support getNetworkInterfaceAsync * add test for getNetworkInterfaceAsync, but disable all tests that require connect to VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
fIx #25398
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines