Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename properties and binder name for eventhubs binder #25430

Conversation

saragluna
Copy link
Member

Description

Rename event hubs binder name and properties prefix from eventhub to eventhubs, and refactor some classes names accordingly. Also, this pr remove the duplicate EventHubProvisioner.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…eventhubs, and refactor some classes names accordingly. Also, this pr remove the duplicate EventHubProvisioner
@ghost ghost added the azure-spring All azure-spring related issues label Nov 16, 2021
@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saragluna saragluna merged commit c7d49d7 into Azure:feature/azure-spring-cloud-4.0 Nov 16, 2021
@saragluna saragluna deleted the xiada/feature/rename-properties-and-binder-name-for-eventhubs-binder branch March 17, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants