mgmt, add generated samples for premium mgmt SDKs #25431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
added
Mgmt
weidongxu-microsoft
requested review from
ArthurMa1978,
haolingdong-msft and
XiaofeiCao
as code owners
|
|
||
| // move generated samples to azure-resourcemanager | ||
| generatedSamplesSource = path.join(mappings[project].dir, '/src/samples/java/', packagePath, 'generated'); | ||
| generatedSamplesTarget = path.join('azure-resourcemanager/src/samples/java/', packagePath); |
There was a problem hiding this comment.
do we need /generated folder?
There was a problem hiding this comment.
Want to have the /generated folder, so it is clear that these are pure generated, and might not have guarantee on its quality.
haolingdong-msft
approved these changes
Nov 16, 2021
XiaofeiCao
pushed a commit
to XiaofeiCao/azure-sdk-for-java
that referenced
this pull request
Nov 18, 2021
* use spec main branch * regen compute * pom * codegen to generate samples and move to azure-resourcemanager * samples for storage * samples for network * samples for compute * samples for ACR * samples for eventhubs * samples for cosmos * samples for AKS * clean sample target folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
fix #25320
Add generated samples for premium mgmt SDKs.
Main change is on the nodejs script 880527f
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines