Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change property prefix for azure active directory related logic. #25434

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Change property prefix for azure active directory related logic. #25434

merged 2 commits into from
Nov 17, 2021

Conversation

chenrujun
Copy link

As title.

@rujche
Change azure active directory related property from "azure.activedire…
31fec9d 
…ctory.*" to "spring.cloud.azure.active-directory.*"
@ghost ghost added the azure-spring All azure-spring related issues label Nov 16, 2021
@chenrujun chenrujun self-assigned this Nov 16, 2021
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Nov 16, 2021
@chenrujun chenrujun added this to the Spring Cloud Azure 4.0 Beta milestone Nov 16, 2021
@stliu
Copy link
Member

stliu commented Nov 16, 2021

why we use "active-directory" instead of "activedirectory"?

@chenrujun
Copy link
Author

@stliu

  1. active-directory easier to read.
  2. If we write activedirectory in IDE, there will appear warning of typo.

@chenrujun
Copy link
Author

Hi, @stliu , @saragluna , please help to review this PR when you have time.

@stliu stliu merged commit 1c251a1 into Azure:feature/azure-spring-cloud-4.0 Nov 17, 2021
@chenrujun chenrujun deleted the change-property-prefix-for-aad branch November 18, 2021 02:30
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Sep 18, 2023
@AzureRestAPISpecReview
CodeGen from PR 25434 in Azure/azure-rest-api-specs
31e81fc 
[Hub Generated] Publish private branch 'azure-kusto/devCM' (Azure#25434)

* introduce version 2023-08-15 base (copy of 2023-05-02)

* [AutoSync] ee0e78b60ea Merged PR 8558577: Start DB soft delete orchestration only if data recoverability enabled

* [AutoSync] 805c12a9c08 Merged PR 8564800: Automatic sync from dev to devCM

* [AutoSync] 4dde0dd1d96 Merged PR 8565943: [Swagger] declare both Location & Azure-AsyncOperation headers

* [AutoSync] 73264aa5f91 Merged PR 8617414: [Swagger] allow zone update on cluster patch

* [AutoSync] 4104e27d106 Merged PR 8629398: [Sawgger] sandboxCustomImage

* OutboundNetworkDependenciesEndpointProperties - EndpointDetail - add ipAddress

---------

Co-authored-by: swagger-automation <swagger@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stliu stliu stliu approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@moarychan moarychan Awaiting requested review from moarychan

@saragluna saragluna Awaiting requested review from saragluna

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhichengliu12581 zhichengliu12581 Awaiting requested review from zhichengliu12581

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrujun @stliu @rujche