Update Security Libraries to New Codesnippet Tooling #25441
Conversation
alzimmermsft
added
the
Client
alzimmermsft
requested review from
ArthurMa1978,
backwind1233,
chenrujun,
g2vinay,
haolingdong-msft,
hui1110,
jialigit,
LarryOsterman,
moarychan,
samvaity,
saragluna,
stliu and
vcolin7
as code owners
alzimmermsft
requested review from
weidongxu-microsoft,
XiaofeiCao and
yiliuTo
as code owners
ghost
added
| <javadocDoclet></javadocDoclet> | ||
| <javadocDocletOptions></javadocDocletOptions> |
There was a problem hiding this comment.
Having empty tags seems a bit odd and is done in almost all libraries. Can we invert this pattern where libraries having a non-empty value would override what's in parent pom? (Of course, this might be easier after majority of the libraries have migrated to the new tool)
There was a problem hiding this comment.
These empty lines will go away once the codesnippet tooling transition is complete. They're empty as the configuration in the parent POM is to enable the previous codesnippet doclet and this empty configuration disables it.
| /** | ||
| * Algorithm. | ||
| */ |
There was a problem hiding this comment.
Was this enforced by the javadoc plugin?
There was a problem hiding this comment.
Yes, I believe something changed where all fields in a serializable class need to have Javadocs
There was a problem hiding this comment.
This is a private field and requiring javadocs on private fields can become tedious. Is there a way to turn this off while generating javadocs?
| @@ -85,7 +84,7 @@ private static Path getConfiguredKeyStorePath() { | |||
|
|
|||
| @SuppressWarnings("removal") | |||
| private static String privilegedGetProperty(String theProp, String defaultVal) { | |||
| return AccessController.doPrivileged( | |||
| return java.security.AccessController.doPrivileged( | |||
There was a problem hiding this comment.
Changes to this file can be reverted.
There was a problem hiding this comment.
So, this is a compiler warning fix for Java 17. Apparently when you suppress warnings for removal, or anything, on the class it doesn't cover import statements and import statements can't be annotated with SuppressWarnings. Making the usage of the class fully-qualified allows for the method to suppress the warning and fix the compilation warning.
|
/check-enforcer override |
|
Test was failing due to a known issue #25422 |
| <javadocDoclet></javadocDoclet> | ||
| <javadocDocletOptions></javadocDocletOptions> |
There was a problem hiding this comment.
Any particular reason we add these empty properties?
There was a problem hiding this comment.
These empty lines will go away once the codesnippet tooling transition is complete. They're empty as the configuration in the parent POM is to enable the previous codesnippet doclet and this empty configuration disables it.
| <codesnippet.skip>false</codesnippet.skip> | ||
| <javadocDoclet></javadocDoclet> | ||
| <javadocDocletOptions></javadocDocletOptions> |
There was a problem hiding this comment.
Do we need this in this project or other perf projects if we are not going to make use of the codesnippets tool in it?
There was a problem hiding this comment.
Until the previous codesnippet tooling is replaced, yes as it will still attempt to run during Javadoc generation
Description
Fixes #7154
Fixes #23845
Fixes #24975
Fixes #24976
Fixes #24977
Fixes #24978
Fixes #24979
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines