Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR web/resource-manager] Fix network trace API bugs #2548

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -515,18 +515,6 @@ public interface WebApps {
*/
Observable<Operation> migrateMySqlAsync(String resourceGroupName, String name, MigrateMySqlRequest migrationRequestEnvelope);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable getNetworkTraceOperationAsync(String resourceGroupName, String name, String operationId);

/**
* Start capturing network packets for the site (To be deprecated).
* Start capturing network packets for the site (To be deprecated).
Expand All @@ -547,7 +535,7 @@ public interface WebApps {
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable startWebSiteNetworkTraceOperationAsync(String resourceGroupName, String name);
Observable<NetworkTrace> startWebSiteNetworkTraceOperationAsync(String resourceGroupName, String name);

/**
* Stop ongoing capturing network packets for the site.
Expand Down Expand Up @@ -711,6 +699,17 @@ public interface WebApps {
*/
Completable startAsync(String resourceGroupName, String name);

/**
* Start capturing network packets for the site.
* Start capturing network packets for the site.
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name The name of the web app.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> startNetworkTraceAsync(String resourceGroupName, String name);

/**
* Stops an app (or deployment slot, if specified).
* Stops an app (or deployment slot, if specified).
Expand All @@ -722,6 +721,17 @@ public interface WebApps {
*/
Completable stopAsync(String resourceGroupName, String name);

/**
* Stop ongoing capturing network packets for the site.
* Stop ongoing capturing network packets for the site.
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name The name of the web app.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable stopNetworkTraceAsync(String resourceGroupName, String name);

/**
* Sync web app repository.
* Sync web app repository.
Expand Down Expand Up @@ -2653,6 +2663,81 @@ public interface WebApps {
*/
Observable<NetworkFeatures> listNetworkFeaturesSlotAsync(String resourceGroupName, String name, String view, String slot);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTraceOperationAsync(String resourceGroupName, String name, String operationId);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTraceOperationV2Async(String resourceGroupName, String name, String operationId);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @param slot Name of the deployment slot. If a slot is not specified, the API will get an operation for the production slot.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTraceOperationSlotAsync(String resourceGroupName, String name, String operationId, String slot);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @param slot Name of the deployment slot. If a slot is not specified, the API will get an operation for the production slot.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTraceOperationV2SlotAsync(String resourceGroupName, String name, String operationId, String slot);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTracesV2Async(String resourceGroupName, String name, String operationId);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @param slot Name of the deployment slot. If a slot is not specified, the API will get an operation for the production slot.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> getNetworkTracesV2SlotAsync(String resourceGroupName, String name, String operationId, String slot);

/**
* Gets perfmon counters for web app.
* Gets perfmon counters for web app.
Expand Down Expand Up @@ -3364,19 +3449,6 @@ public interface WebApps {
*/
Observable<FunctionSecrets> listSyncFunctionTriggersSlotAsync(String resourceGroupName, String name, String slot);

/**
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
* Gets a named operation for a network trace capturing (or deployment slot, if specified).
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name Name of the app.
* @param operationId GUID of the operation.
* @param slot Name of the deployment slot. If a slot is not specified, the API will get an operation for the production slot.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable getNetworkTraceOperationSlotAsync(String resourceGroupName, String name, String operationId, String slot);

/**
* Start capturing network packets for the site (To be deprecated).
* Start capturing network packets for the site (To be deprecated).
Expand All @@ -3399,7 +3471,7 @@ public interface WebApps {
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable startWebSiteNetworkTraceOperationSlotAsync(String resourceGroupName, String name, String slot);
Observable<NetworkTrace> startWebSiteNetworkTraceOperationSlotAsync(String resourceGroupName, String name, String slot);

/**
* Stop ongoing capturing network packets for the site.
Expand Down Expand Up @@ -3577,6 +3649,18 @@ public interface WebApps {
*/
Completable startSlotAsync(String resourceGroupName, String name, String slot);

/**
* Start capturing network packets for the site.
* Start capturing network packets for the site.
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name The name of the web app.
* @param slot The name of the slot for this web app.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Observable<NetworkTrace> startNetworkTraceSlotAsync(String resourceGroupName, String name, String slot);

/**
* Stops an app (or deployment slot, if specified).
* Stops an app (or deployment slot, if specified).
Expand All @@ -3589,6 +3673,18 @@ public interface WebApps {
*/
Completable stopSlotAsync(String resourceGroupName, String name, String slot);

/**
* Stop ongoing capturing network packets for the site.
* Stop ongoing capturing network packets for the site.
*
* @param resourceGroupName Name of the resource group to which the resource belongs.
* @param name The name of the web app.
* @param slot The name of the slot for this web app.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
*/
Completable stopNetworkTraceSlotAsync(String resourceGroupName, String name, String slot);

/**
* Sync web app repository.
* Sync web app repository.
Expand Down
Loading