-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javadoc and url link warnings of api-reivew #25896
Merged
saragluna
merged 4 commits into
Azure:feature/azure-spring-cloud-4.0
from
backwind1233:20211208-apireview-gzh
Dec 9, 2021
Merged
Fix javadoc and url link warnings of api-reivew #25896
saragluna
merged 4 commits into
Azure:feature/azure-spring-cloud-4.0
from
backwind1233:20211208-apireview-gzh
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwind1233
requested review from
chenrujun,
hui1110,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
December 8, 2021 09:23
@saragluna please help review this PR. |
saragluna
requested changes
Dec 8, 2021
...-core/src/main/java/com/azure/spring/core/resource/AbstractAzureStorageProtocolResolver.java
Outdated
Show resolved
Hide resolved
saragluna
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging this pr now for the ci failed of some pipeline issues. |
2 tasks
2 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896) * Copying the previous version to the new version folder * Changed the swagger version to the new one * Updating the new version changes * Updated examples for the new versions * Reverting change in the existing version swagger * Fixing the semantic validation error * upgrading to v5 for common file * Adding x-ms-long-running-operation in Patch call * Updated the return code from 201 to 202 for Patch calls * Fixes for model validation * Fixing prettier check * Added patch call schema * Update the patch update sap instance property structure * Update location in examples and object description changes * Removed 200 code for Delete to fix the linter check * Removed 200 code for child instance delete calls
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896) * Copying the previous version to the new version folder * Changed the swagger version to the new one * Updating the new version changes * Updated examples for the new versions * Reverting change in the existing version swagger * Fixing the semantic validation error * upgrading to v5 for common file * Adding x-ms-long-running-operation in Patch call * Updated the return code from 201 to 202 for Patch calls * Fixes for model validation * Fixing prettier check * Added patch call schema * Update the patch update sap instance property structure * Update location in examples and object description changes * Removed 200 code for Delete to fix the linter check * Removed 200 code for child instance delete calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title:
It's mainly about the java doc warnings.