Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc and url link warnings of api-reivew #25896

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Fix javadoc and url link warnings of api-reivew #25896

merged 4 commits into from
Dec 9, 2021

Conversation

backwind1233
Copy link
Contributor

As title:
It's mainly about the java doc warnings.

@ghost ghost added the azure-spring All azure-spring related issues label Dec 8, 2021
@backwind1233
Copy link
Contributor Author

@saragluna please help review this PR.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna
Copy link
Member

Merging this pr now for the ci failed of some pipeline issues.

@saragluna saragluna merged commit cc92e8c into Azure:feature/azure-spring-cloud-4.0 Dec 9, 2021
@backwind1233 backwind1233 linked an issue Dec 13, 2021 that may be closed by this pull request
2 tasks
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896)

* Copying the previous version to the new version folder

* Changed the swagger version to the new one

* Updating the new version changes

* Updated examples for the new versions

* Reverting change in the existing version swagger

* Fixing the semantic validation error

* upgrading to v5 for common file

* Adding x-ms-long-running-operation in Patch call

* Updated the return code from 201 to 202 for Patch calls

* Fixes for model validation

* Fixing prettier check

* Added patch call schema

* Update the patch update sap instance property structure

* Update location in examples and object description changes

* Removed 200 code for Delete to fix the linter check

* Removed 200 code for child instance delete calls
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896)

* Copying the previous version to the new version folder

* Changed the swagger version to the new one

* Updating the new version changes

* Updated examples for the new versions

* Reverting change in the existing version swagger

* Fixing the semantic validation error

* upgrading to v5 for common file

* Adding x-ms-long-running-operation in Patch call

* Updated the return code from 201 to 202 for Patch calls

* Fixes for model validation

* Fixing prettier check

* Added patch call schema

* Update the patch update sap instance property structure

* Update location in examples and object description changes

* Removed 200 code for Delete to fix the linter check

* Removed 200 code for child instance delete calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API review for Storage + Database modules
2 participants