Modify for messaging apireview #26200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure/azure-sdk-for-java into add-javadoc-for-integration
…zure/azure-sdk-for-java into add-javadoc-for-integration
…zure/azure-sdk-for-java into add-javadoc-for-integration
yiliuTo
added
Client
yiliuTo
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
saragluna and
stliu
as code owners
saragluna
requested changes
Dec 28, 2021
| @@ -137,10 +136,10 @@ protected MessageProducer createConsumerEndpoint(ConsumerDestination destination | |||
| buildCheckpointConfig(properties)); | |||
| } | |||
| inboundAdapter.setBeanFactory(getBeanFactory()); | |||
| String instrumentationId = Instrumentation.buildId(CONSUMER, destination.getName() + "/" + (!INVALID_SUBSCRIPTION.equals(group) ? group : "")); | |||
| String instrumentationId = Instrumentation.buildId(CONSUMER, destination.getName() + "/" + (!INVALID_GROUP.equals(group) ? group : "")); | |||
There was a problem hiding this comment.
Can we extract a private method for this (!INVALID_GROUP.equals(group) ? group : "")
...ain/java/com/azure/spring/cloud/stream/binder/servicebus/ServiceBusMessageChannelBinder.java
Show resolved
Hide resolved
|
/azp run java - sping - tests |
|
No pipelines are associated with this pull request. |
|
/azp run java - spring - tests |
saragluna
requested changes
Dec 28, 2021
...a/com/azure/spring/servicebus/core/processor/DefaultServiceBusNamespaceProcessorFactory.java
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
requested changes
Dec 28, 2021
| @@ -137,10 +132,10 @@ protected MessageProducer createConsumerEndpoint(ConsumerDestination destination | |||
| buildCheckpointConfig(properties)); | |||
There was a problem hiding this comment.
Seems like here we can adjust the ServiceBusInboundChannelAdapter constructor to always receives destination and group, and decide whether it's a queue internally?
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
modified the milestones:
Spring Cloud Azure 4.0 GA,
Spring Cloud Azure 4.0 Beta3
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 12, 2023
[TypeSpec] Upgrade to 0.49.0 (Azure#26200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spring-messaging-azure-* libraries according to api-review results.
Ref:
spring-messaging-azure-servicebus: https://apiview.dev/Assemblies/Review/72aca2ba5bd7413aabc8cbe99e06acf4
spring-messaging-azure-eventhubs: https://apiview.dev/Assemblies/Review/58995c5facde49aa8898510ae955d5b6#
spring-messaging-azure-storage-queue: https://apiview.dev/Assemblies/Review/fba59870bb51473db28b423394a1a75a