Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rev API Issues Jan 2022 #26455

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Fix Rev API Issues Jan 2022 #26455

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c62fcf4
update
Jan 13, 2022
72e15df
update
Jan 13, 2022
30c2db6
update
Jan 13, 2022
362edcb
update
Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion eng/code-quality-reports/src/main/resources/revapi/revapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,37 @@
"code": "java.method.added",
"new": "method java.lang.Class<T> com.azure.core.util.serializer.TypeReference<T>::getJavaClass()",
"justification": "New method added to TypeReference in azure-core."
}
},
{
"code": "java.method.added",
"new": "method void com.azure.core.util.logging.ClientLogger::<init>(java.lang.Class<?>, java.util.Map<java.lang.String, java.lang.Object>)",
"justification": "New method added to ClientLogger in azure-core."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should also include the azure-core version that caused this and when all client libraries have moved past that version, we should remove this suppression.

},
{
"code": "java.method.added",
"new": "method void com.azure.core.util.logging.ClientLogger::<init>(java.lang.String, java.util.Map<java.lang.String, java.lang.Object>)",
"justification": "New method added to ClientLogger in azure-core."
},
{
"code": "java.method.added",
"new": "method com.azure.core.util.logging.LoggingEventBuilder com.azure.core.util.logging.ClientLogger::atError()",
"justification": "New method added to ClientLogger in azure-core."
},
{
"code": "java.method.added",
"new": "method com.azure.core.util.logging.LoggingEventBuilder com.azure.core.util.logging.ClientLogger::atInfo()",
"justification": "New method added to ClientLogger in azure-core."
},
{
"code": "java.method.added",
"new": "method com.azure.core.util.logging.LoggingEventBuilder com.azure.core.util.logging.ClientLogger::atVerbose()",
"justification": "New method added to ClientLogger in azure-core."
},
{
"code": "java.method.added",
"new": "method com.azure.core.util.logging.LoggingEventBuilder com.azure.core.util.logging.ClientLogger::atWarning()",
"justification": "New method added to ClientLogger in azure-core."
}
]
}
}
Expand Down