Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change codespaces to use default universal image #28581

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Apr 28, 2022

Codespaces are currently broken due to docker init issues. The latest universal image already contains docker. This change removes our custom docker work and uses the default universal image.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@hallipr hallipr force-pushed the hallipr/codespaces branch from 1530532 to b69fdf9 Compare April 28, 2022 19:06
@hallipr hallipr requested review from weshaggard and benbp April 28, 2022 19:44
@hallipr hallipr enabled auto-merge (squash) April 28, 2022 19:44
@hallipr
Copy link
Member Author

hallipr commented Apr 29, 2022

This change has no verification pipeline. Skipping checkenforcer.

@hallipr
Copy link
Member Author

hallipr commented Apr 29, 2022

/check-enforcer override

@hallipr hallipr merged commit bb4cb25 into main Apr 29, 2022
@hallipr hallipr deleted the hallipr/codespaces branch April 29, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants