Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Configuration - Preview Feature Variants #28701

Merged

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented May 6, 2022

No description provided.

@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label May 6, 2022
@azure-sdk
Copy link
Collaborator

API change check for com.azure.spring:azure-spring-cloud-appconfiguration-config

API changes have been detected in com.azure.spring:azure-spring-cloud-appconfiguration-config. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for com.azure.spring:azure-spring-cloud-feature-management

API changes have been detected in com.azure.spring:azure-spring-cloud-feature-management. You can review API changes here

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 6, 2022

API change check for com.azure.spring:azure-spring-cloud-feature-management-web

API changes have been detected in com.azure.spring:azure-spring-cloud-feature-management-web. You can review API changes here

API changes

+     public class DynamicFeatureManagerSnapshot {
+         public DynamicFeatureManagerSnapshot(DynamicFeatureManager dynamicFeatureManager) 
+         public <T> Mono<T> getVariantAsync(String variantName, Class<T> type) 
+     }
+     @Configuration
+         @Bean @RequestScope public DynamicFeatureManagerSnapshot dynamicFeatureManagerSnapshot(DynamicFeatureManager dynamicFeatureManager) 

@azure-sdk
Copy link
Collaborator

API change check for com.azure.spring:azure-spring-cloud-appconfiguration-config-web

API changes are not detected in this pull request for com.azure.spring:azure-spring-cloud-appconfiguration-config-web

@saragluna saragluna self-assigned this May 17, 2022
@saragluna saragluna added this to the [2022] June milestone May 17, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 17, 2022

@mrm9084 mrm9084 changed the base branch from main to feature/azconfig-spring/DynamicFeature June 21, 2022 03:56
@saragluna
Copy link
Member

We'd better mark this PR as ready for review.

@saragluna
Copy link
Member

saragluna commented Jun 21, 2022

@saragluna
Copy link
Member

Seems like this API review still has some warnings https://apiview.dev/Assemblies/Review/a8e6522e59ea40ccb18997f5491df348

@mrm9084
Copy link
Member Author

mrm9084 commented Jun 21, 2022

Seems like this API review still has some warnings https://apiview.dev/Assemblies/Review/a8e6522e59ea40ccb18997f5491df348

I am not sure what that is referencing as that is the old azure-spring-cloud package name, and it was deleted.

@mrm9084 mrm9084 changed the title App Configuration - Preview Feature Variants (Do Not Merge) App Configuration - Preview Feature Variants Jun 21, 2022
@mrm9084 mrm9084 marked this pull request as ready for review June 21, 2022 23:27
@mrm9084 mrm9084 merged commit cb9b59f into Azure:feature/azconfig-spring/DynamicFeature Jun 22, 2022
@mrm9084 mrm9084 deleted the DynamicFeatureNew branch June 22, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants