Release/azure communication common/1.1.3 #28730
Conversation
martinbarnas-ms
requested review from
alzimmermsft,
samvaity,
g2vinay,
srnagar,
JonathanGiles,
JianpingChen,
ankitarorabit,
minnieliu,
a team,
joshfree,
anuchandy,
conniey,
pallavit and
lmolkova
as code owners
ghost
added
the
|
API change check for API changes are not detected in this pull request for |
| @@ -65,17 +65,17 @@ | |||
| <dependency> | |||
| <groupId>org.apache.maven</groupId> | |||
| <artifactId>maven-plugin-api</artifactId> | |||
| <version>3.8.1</version> <!-- {x-version-update;org.apache.maven:maven-plugin-api;external_dependency} --> | |||
| <version>1.0.0-beta.2</version> <!-- {x-version-update;com.azure.tools:azure-sdk-build-tool;current} --> | |||
There was a problem hiding this comment.
Hmm, I feel I've seen this bug happen before where the tools POM has this random versioning change happen, you'll need to revert the changes to this file.
@JimSuplizio, @hallipr do either of you know what would cause this to happen?
There was a problem hiding this comment.
Changes in this file reverted.
| @@ -23,7 +23,7 @@ | |||
| <plugin> | |||
| <groupId>org.jacoco</groupId> | |||
| <artifactId>jacoco-maven-plugin</artifactId> | |||
| <version>0.8.5</version> <!-- {x-version-update;org.jacoco:jacoco-maven-plugin;external_dependency} --> | |||
| <version>0.8.7</version> <!-- {x-version-update;org.jacoco:jacoco-maven-plugin;external_dependency} --> | |||
There was a problem hiding this comment.
@JimSuplizio, @hallipr would either of you know if the directory root POMs are being excluded in version checks? The jacoco-maven-plugin version is commonly seen out of date in the root POMs and normally I'd think this would have prevented check-in.
No changes needed in this PR, just wanted to start a discussion on this.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines