-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics API in azure-core and otel implementation #29086
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/core/azure-core/src/main/java/com/azure/core/util/metrics/DefaultMeterProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...elemetry/src/main/java/com/azure/core/metrics/opentelemetry/OpenTelemetryMetricsOptions.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/TelemetryAttributes.java
Show resolved
Hide resolved
Thanks @lmolkova @yiliuTo @saragluna FYI, now we are able to start the issue of enabling metrics in spring |
@stliu @yiliuTo @saragluna let me know if you need any help! Note that SDKs don't emit metrics yet, we just have API to start doing it, but stay tuned for AMQP metrics coming - I hope to have the first AMQP metrics (from core) coming next month. |
Fixes #25603 and #25604
Context: https://gist.github.com/lmolkova/b9004307a09be788af04f05ebe22ad3c
Introduces metrics API in azure-core and its implementation in azure-core-metrics-opentelemetry.
Micrometer-based implementation is included as a sample.
Micro-benchmarks: <100 ns per measurement (~30 of them in
Instant.now()
x2), no allocationsPerf-tests: EvenHubs producer test ~6% overhead, need more work to properly measure:
EventHubs advanced usage prototype (perf-tested above):
https://github.com/lmolkova/azure-sdk-for-java/blob/9bc8e11b420ca91ad8760283a064044e88781d3a/sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubProducerAsyncClient.java#L601
https://github.com/lmolkova/azure-sdk-for-java/blob/metrics-api-proto/sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubsMetricProducerMetricHelper.java