Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for azure-cosmos 4.30.1 and adding reason to rntbd channel health check failures #29174

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Release for azure-cosmos 4.30.1 and adding reason to rntbd channel health check failures #29174

merged 4 commits into from
Jun 2, 2022

Conversation

FabianMeiswinkel
Copy link
Member

Description

Release bureaucracy as well as adding additional information about the reason into the UnhealthyChannelException to simplify debugging these situations without enabling custom Log4J logs of the RntbdClientHealthChecker form the implementation package.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

@ghost ghost added Cosmos azure-spring All azure-spring related issues labels Jun 1, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

ealsur
ealsur approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just some open questions

@FabianMeiswinkel FabianMeiswinkel merged commit 9129dc0 into Azure:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@samvaity samvaity Awaiting requested review from samvaity

@g2vinay g2vinay Awaiting requested review from g2vinay

@srnagar srnagar Awaiting requested review from srnagar

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@Netyyyy Netyyyy Awaiting requested review from Netyyyy

@saragluna saragluna Awaiting requested review from saragluna

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@milismsft milismsft Awaiting requested review from milismsft

@aayush3011 aayush3011 Awaiting requested review from aayush3011

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FabianMeiswinkel @azure-sdk @ealsur @kirankumarkolli