Fixed Store Response headers case insensitivity #29210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
FabianMeiswinkel,
kirankumarkolli,
mbhaskar,
simplynaveen20,
xinlian12,
milismsft and
aayush3011
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
j82w
reviewed
Jun 3, 2022
...ure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreClient.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
requested changes
Jun 7, 2022
| byte[] content) { | ||
|
|
||
| requestTimeline = RequestTimeline.empty(); | ||
| responseHeaders = new ConcurrentHashMap<>(headerMap); |
There was a problem hiding this comment.
Why not just use java.util.concurrent.ConcurrentSkipListMap here instead?
|
Here is an alternative which does not fallback to arrays - #29268 |
|
close due to PR #29268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StoreResponseheaders - Improved diagnostics with new models for StoreResponse, StoreResult and CosmosException #28620SortedMapwith comparator implemented for case insensitivity. This will be done in future PRs.