Add stress tests module for Service Bus #29407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liukun-msft
force-pushed
the
feature/sb-stress-test
branch
from
458a8b9 to
c50c222
Compare
liukun-msft
force-pushed
the
feature/sb-stress-test
branch
from
c50c222 to
4ad9809
Compare
ghost
added
the
no-recent-activity
ghost
closed this
ghost
removed
the
no-recent-activity
liukun-msft
requested review from
hallipr,
JimSuplizio,
alzimmermsft,
samvaity,
g2vinay,
anuchandy,
ki1729,
conniey and
ZejiaJiang
as code owners
liukun-msft
commented
Nov 11, 2022
conniey
reviewed
Nov 15, 2022
| }) | ||
| .buildProcessorClient(); | ||
|
|
||
| client.start(); |
There was a problem hiding this comment.
Do we need to close the client when the program ends?
There was a problem hiding this comment.
Same with other clients. Does clean-up matter?
There was a problem hiding this comment.
I'll add close() for sender and sync receiver since we know the total send/receive messages. But for processor and async receiver, we don't know when we can close it. We keep the processor running until we manually shut down or deploy another test. If someone needs to, they can add a fix duration to processor test.
The clean-up will not impact test running and its results. Because we will run each test scenraio on different resource groups and all resources are auto-deleted after we end the test.
ki1729
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add service bus stress tests project base on azure-sdk-chaos.
Resolve #23953.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines