Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment credential cert password #30032

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Environment credential cert password #30032

merged 3 commits into from
Jul 20, 2022

Conversation

billwert
Copy link
Contributor

@billwert billwert commented Jul 19, 2022 •
edited
Loading

Fixes #29150.

Now we will read the password for a certificate in EnvironmentCredential.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Azure.Core azure-core Azure.Identity labels Jul 19, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 19, 2022 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core
azure-identity

g2vinay
g2vinay approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@g2vinay g2vinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to check, if we're doing this in other languages or not.

@billwert billwert merged commit 4a53adf into Azure:main Jul 20, 2022
@saragluna saragluna mentioned this pull request Aug 3, 2022
Closed
2 tasks
@billwert billwert deleted the environment-credential-cert-password branch April 4, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@g2vinay g2vinay g2vinay approved these changes

@schaabs schaabs Awaiting requested review from schaabs

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

Assignees
No one assigned
Labels
Azure.Core azure-core Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] EnvironmentCredential supports certificate passwords
4 participants
@billwert @azure-sdk @g2vinay @alzimmermsft