Add ServiceProvider Interface to azure-json and azure-xml #30635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
mssfang,
JonathanGiles,
srnagar,
anuchandy,
lmolkova,
vcolin7,
billwert and
kasobol-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
lmolkova
approved these changes
Sep 1, 2022
| /** | ||
| * Contains configuration options for creating a {@link JsonReader} or {@link JsonWriter}. | ||
| */ | ||
| public final class JsonOptions { |
There was a problem hiding this comment.
future concern: we probably should allow implementations to have implementation-specific options and then would need to plumb jsonoptions through clients.
There was a problem hiding this comment.
Yep! Once we want to allow for implementation specific options we can make this class non-final
kwonus-msft
pushed a commit
to kwonus-msft/azure-sdk-for-java-kw
that referenced
this pull request
Sep 1, 2022
Add ServiceProvider Interface to azure-json and azure-xml
vcolin7
pushed a commit
to vcolin7/azure-sdk-for-java
that referenced
this pull request
Sep 9, 2022
Add ServiceProvider Interface to azure-json and azure-xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
ServiceProviderinterface to bothazure-jsonandazure-xmland adds implementation of theazure-jsoninterface toazure-json-gsonto enable loading implementations found on the classpath. Both the JSON and XML providers also offer a default fallback when an instance cannot be found on the classpath and this is the default handling.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines