Adding new overload with length for BlobAsyncClient.upload() #30672
Conversation
ibrahimrabab
requested review from
rickle-msft,
jaschrep-msft,
alzimmermsft and
kasobol-msft
as code owners
ghost
added
the
|
I wonder if a better approach to this would be leveraging the fact that This would hook into the |
|
API change check API changes are not detected in this pull request. |
| // Since we already know the size of our buffered bytes, we can pass the ByteBuffer and length to the BinaryData. | ||
| // This will internally convert the BinaryData to a Flux<ByteBuffer>, but with known length we can optimize the | ||
| // upload speed. | ||
| BinaryData binaryData = BinaryData.fromFlux(sourceData, length).block(); |
There was a problem hiding this comment.
Two minor nits:
- This returns a reactive response and can be reactively chained
- There is two Flux length APIs in BinaryData, the one being used here will buffer the stream whereas the overload will allow this to be configured. We should call that out here
ibrahimrabab
requested review from
alzimmermsft
and removed request for
rickle-msft and
kasobol-msft
resolves #6090
Instead of adding a new overload, we add a sample users can refer to in order to use upload method for a ByteBuffer with a known size.