Client Encryption: Adds fix to allow partition key path and id to be part of client encryption policy. #30678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayush3011
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12 and
milismsft
as code owners
abhijitpai
reviewed
Aug 28, 2022
|
@aayush3011 can you please also link the corresponding .Net PR in this PR description. |
kushagraThapar
requested changes
Sep 2, 2022
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ClientEncryptionPolicy.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ClientEncryptionPolicy.java
Outdated
Show resolved
Hide resolved
kushagraThapar
requested changes
Sep 2, 2022
| */ | ||
| @Beta(value = Beta.SinceVersion.V4_14_0, warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING) | ||
| public ClientEncryptionPolicy(List<ClientEncryptionIncludedPath> paths, int policyFormatVersion) { | ||
| if (policyFormatVersion > 2 || policyFormatVersion < 1) { |
There was a problem hiding this comment.
I think we can make policyFormatVersion immutable (so that it is initialized only once per ClientEncryptionPolicy).
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ClientEncryptionPolicy.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ClientEncryptionPolicy.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ClientEncryptionPolicy.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
aayush3011
requested review from
samvaity,
g2vinay,
JimSuplizio,
srnagar and
JonathanGiles
as code owners
…m:aayush3011/azure-sdk-for-java into users/akataria/EncryptionPartitionKeyPath
|
@aayush3011 What is the status on this PR? |
ghost
added
the
no-recent-activity
|
Hi @aayush3011. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
removed
the
no-recent-activity
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
.Net PRs:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines