[TA] Client side validation #30708
Merged
[TA] Client side validation #30708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mssfang
added
the
Client
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Yeah. Java also should update the docstring. Added the docstring. |
heaths
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Did you also want to add the serviceLogsDisabled "property" to the newer actions like I did in Azure/azure-sdk-for-net#30753 as well? Makes everything consistent; though, could be another PR. No need to validate those, though, since they only exist for 2022-05-01 and newer anyway.
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Outdated
Show resolved
Hide resolved
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Show resolved
Hide resolved
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Show resolved
Hide resolved
.../azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java
Show resolved
Hide resolved
...zure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClient.java
Show resolved
Hide resolved
kristapratico
approved these changes
Aug 31, 2022
deyaaeldeen
reviewed
Aug 31, 2022
.../azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java
Show resolved
Hide resolved
deyaaeldeen
reviewed
Aug 31, 2022
.../azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java
Show resolved
Hide resolved
deyaaeldeen
reviewed
Sep 1, 2022
...e-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeSentimentAsyncClient.java
Show resolved
Hide resolved
deyaaeldeen
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the v-team shared client-side validation