Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getSchema using group name, schema name, and version #31167

Merged
merged 16 commits into from
Sep 29, 2022
Merged

Add getSchema using group name, schema name, and version #31167

merged 16 commits into from
Sep 29, 2022

Conversation

conniey
Copy link
Member

@conniey conniey commented Sep 27, 2022

Description

  • Adds `getSchema(groupName, schemaName, version)
  • Adds getVersion to SchemaProperties.

Fixes #30822

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey self-assigned this Sep 27, 2022
@ghost ghost added the Schema Registry label Sep 27, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-data-schemaregistry

anuchandy
anuchandy approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Connie! LGTM. (I skipped all generated files and looked only the convenience layer files)

...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java Outdated Show resolved Hide resolved
...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java Show resolved Hide resolved
...data-schemaregistry/src/main/java/com/azure/data/schemaregistry/models/SchemaProperties.java Show resolved Hide resolved
@conniey conniey merged commit 12ace8e into Azure:main Sep 29, 2022
@conniey conniey deleted the generate-schemaregistry branch September 29, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@sjkwak sjkwak Awaiting requested review from sjkwak

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees

@conniey conniey

Labels
Schema Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a function for fetching schema from Schema Registry using group name, schema name and schema version
3 participants
@conniey @azure-sdk @anuchandy