-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README of azure-identity-providers-jdbc-[mysql/postgresql] libraries #31380
Merged
backwind1233
merged 6 commits into
Azure:main
from
backwind1233:update_jdbc_readme_documentation_gzh
Oct 14, 2022
Merged
Update README of azure-identity-providers-jdbc-[mysql/postgresql] libraries #31380
backwind1233
merged 6 commits into
Azure:main
from
backwind1233:update_jdbc_readme_documentation_gzh
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwind1233
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
October 11, 2022 09:19
saragluna
reviewed
Oct 11, 2022
saragluna
reviewed
Oct 11, 2022
saragluna
reviewed
Oct 11, 2022
saragluna
requested changes
Oct 11, 2022
Hi @fangjian0423 could you help review this PR? |
fangjian0423
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saragluna
requested changes
Oct 12, 2022
backwind1233
requested review from
chenrujun,
hui1110,
Netyyyy,
stliu,
yiliuTo and
moarychan
as code owners
October 13, 2022 09:29
API change check API changes are not detected in this pull request. |
saragluna
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some improvements:
Docs
azure-storage-blob
azure-identity.