Add metadata for spring.datasource.azure.passwordless-enabled
#31976
Conversation
backwind1233
requested review from
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo,
moarychan and
fangjian0423
as code owners
ghost
added
the
backwind1233
added
Client
|
API change check API changes are not detected in this pull request. |
| { | ||
| "name": "spring.datasource.azure.passwordless-enabled", | ||
| "type": "java.lang.Boolean", | ||
| "description": "Whether to enable supporting Azure identity token credentials.", |
There was a problem hiding this comment.
| "description": "Whether to enable supporting Azure identity token credentials.", | |
| "description": "Whether to enable passwordless connections to Azure databases by using Azure Active Directory token credentials.", |
There was a problem hiding this comment.
Good point, I think we need to update our docs, codes as well.
There was a problem hiding this comment.
Should we add OAuth2 before the token credentials
There was a problem hiding this comment.
I hava updated this description to "Whether to enable passwordless connections to Azure databases by using OAuth2 Azure Active Directory token credentials." ,check here.
| "name": "spring.datasource.azure.passwordless-enabled", | ||
| "type": "java.lang.Boolean", | ||
| "description": "Whether to enable supporting Azure identity token credentials.", | ||
| "sourceType": "com.azure.spring.cloud.service.implementation.passwordless.AzurePasswordlessProperties", |
There was a problem hiding this comment.
Do you think we can skip this sourceType here?
There was a problem hiding this comment.
If users can still jump to AzurePasswordlessProperties from IDE, then I think we can remove it.
There was a problem hiding this comment.
But what can the users benefit from the jumping?
There was a problem hiding this comment.
But what can the users benefit from the jumping?
The point here is what's the expectation of users, I think by default users will have the expectation that it would be able to jump to a property class.
metadata of
spring.datasource.azure.passwordless-enabledcan't be generated by spring-boot, we should add these metadata manully.Follow-up issue #32124.