Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property assumeMinServerVersion for jdbc postgresql passwordless connections #32304

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Add property assumeMinServerVersion for jdbc postgresql passwordless connections #32304

merged 3 commits into from
Nov 24, 2022

Conversation

backwind1233
Copy link
Contributor

@backwind1233 backwind1233 commented Nov 23, 2022

Context

While users using our library:spring-cloud-azure-starter-jdbc-postgresql, we want to add a application_name property in the jdbc connection url, but only user is explicitly telling the driver he using is a 9.0+ postgresql server, then the log of setting application_name property can be executed.

In order to add application_name property in the jdbc connection url, we have to add a property assumeMinServerVersion to explicitly telling the postgresql driver.

@ghost ghost added the azure-spring All azure-spring related issues label Nov 23, 2022
@backwind1233 backwind1233 self-assigned this Nov 23, 2022
@backwind1233 backwind1233 added the Client This issue points to a problem in the data-plane of the library. label Nov 23, 2022
@backwind1233 backwind1233 added this to the 2022-12 milestone Nov 23, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to the spring level, to make sure that with our configuration, the application name can be set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants