Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct some word errors and add a picture in readme. #32536

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Correct some word errors and add a picture in readme. #32536

merged 7 commits into from
Dec 12, 2022

Conversation

backwind1233
Copy link
Contributor

Description

  • Correct some word errors.
  • Add a new picture to show the architecture.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Identity label Dec 9, 2022
@backwind1233 backwind1233 self-assigned this Dec 9, 2022
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Dec 9, 2022
@backwind1233 backwind1233 added this to the 2023-01 milestone Dec 9, 2022
@backwind1233 backwind1233 added the Client This issue points to a problem in the data-plane of the library. label Dec 9, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@backwind1233 @saragluna
Update sdk/identity/azure-identity-extensions/README.md
5528ae2 
Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>
saragluna
saragluna requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toc in sdk/identity/azure-identity-extensions/README.md file is not correct.

@saragluna saragluna merged commit 8c6d665 into Azure:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees

@backwind1233 backwind1233

Labels
Azure.Identity azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Status: Done
Milestone
2023-01
Development

Successfully merging this pull request may close these issues.
3 participants
@backwind1233 @azure-sdk @saragluna