Integrate sync stack in schema registry via AutoRest. #32576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
g2vinay
commented
Dec 12, 2022
...a-schemaregistry/src/main/java/com/azure/data/schemaregistry/implementation/SchemasImpl.java
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Dec 19, 2022
...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java
Outdated
Show resolved
Hide resolved
...re-data-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClient.java
Show resolved
Hide resolved
...src/main/java/com/azure/data/schemaregistry/implementation/models/SchemasGetByIdHeaders.java
Show resolved
Hide resolved
srnagar
approved these changes
Jan 12, 2023
...re-data-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClient.java
Show resolved
Hide resolved
...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java
Show resolved
Hide resolved
...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jan 18, 2023
...egistry/src/main/java/com/azure/data/schemaregistry/implementation/SchemaRegistryHelper.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jan 18, 2023
...-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClientBuilder.java
Outdated
Show resolved
Hide resolved
added 6 commits
January 27, 2023 10:05
|
/azp run java - schemaregistry - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
conniey
reviewed
Feb 21, 2023
...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java
Show resolved
Hide resolved
| @@ -197,7 +211,7 @@ public SchemasGetByIdHeaders setLocation(String location) { | |||
| * | |||
| * @return the contentType value. | |||
| */ | |||
| public SchemaFormatImpl getContentType() { | |||
| public SchemaFormat getContentType() { | |||
There was a problem hiding this comment.
Curious why the change from SchemaFormatImpl -> SchemaFormat? I think there is a collision with the public-facing one so we have to qualify it. :/
There was a problem hiding this comment.
This is done by Autorest, we can revert this if its a breaking change ?
conniey
approved these changes
Feb 22, 2023
|
/azp run java - schemaregistry - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Sync Stack in Schema Registry via AutoRest, also enables ResponseBase in Schema Registry via AutoRest.