Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SyncStack-TextAnlytics] Add SyncStack support in TA #32867

Merged
merged 11 commits into from
Jan 26, 2023
Merged

[SyncStack-TextAnlytics] Add SyncStack support in TA #32867

merged 11 commits into from
Jan 26, 2023

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Jan 11, 2023 •
edited
Loading

Description

Adding SyncStack support in Text Analytics.

All files under "/implementation" are updated by autorest. EXCEPT

  • "implementation/TextAnalyticsClientImpl.java" // Since TA client has legacy API Versions before Cognitive-Language consolidation.
  • "implementation/Utility.java"

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Jan 11, 2023
@mssfang mssfang added this to the 2023-02 milestone Jan 11, 2023
@mssfang mssfang requested a review from g2vinay January 11, 2023 01:13
@mssfang mssfang self-assigned this Jan 11, 2023
@mssfang mssfang requested a review from samvaity as a code owner January 11, 2023 01:13
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-textanalytics

@mssfang mssfang requested a review from alzimmermsft January 18, 2023 19:10
@g2vinay
Copy link
Member

g2vinay commented Jan 23, 2023

Update Sync and Async unit tests setup to use AssertingHttpClient from azure-core-test, this will ensure the Sync Stack flow is being properly triggered in Text Analytics.

@mssfang mssfang requested a review from samvaity January 24, 2023 20:27
@mssfang
Copy link
Member Author

mssfang commented Jan 24, 2023

/azp run java - textanalytics - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

samvaity
samvaity approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

...zure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsUtilClient.java Show resolved Hide resolved
...extanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeHealthcareEntityUtilClient.java Outdated Show resolved Hide resolved
@samvaity
Copy link
Member

samvaity commented Jan 25, 2023 •
edited
Loading

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang
Copy link
Member Author

mssfang commented Jan 25, 2023

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang mssfang requested a review from g2vinay January 25, 2023 21:24
@mssfang
Copy link
Member Author

mssfang commented Jan 25, 2023

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang
Copy link
Member Author

mssfang commented Jan 26, 2023

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang
Copy link
Member Author

mssfang commented Jan 26, 2023

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang mssfang merged commit 7b7b901 into Azure:main Jan 26, 2023
@mssfang mssfang deleted the TA-SyncStack-Language branch January 26, 2023 15:45
@samvaity samvaity mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@g2vinay g2vinay g2vinay approved these changes

@srnagar srnagar Awaiting requested review from srnagar

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

Assignees

@mssfang mssfang

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
2023-02
Development

Successfully merging this pull request may close these issues.
5 participants
@mssfang @azure-sdk @g2vinay @samvaity @alzimmermsft