Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Eng Sys rules in CODEOWNERS + assorted fixes #33309

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Restore Eng Sys rules in CODEOWNERS + assorted fixes #33309

merged 1 commit into from
Feb 8, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 3, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 3, 2023
@konrad-jamrozik konrad-jamrozik force-pushed the users/kojamroz/fix_co_2_2_2023 branch from c9302b1 to 228134c Compare February 3, 2023 02:10
@konrad-jamrozik
Copy link
Contributor Author

@jsquire if I enable the new regex-based wildcard-supporting CODEOWNERS matcher the build failure notifications recipients will change, like so (from LEFT OWNERS to RIGHT OWNERS):

image

Can you let me know if this is OK? Should I reach out to the affected owners to ask about it? Note this routing change is not yet in effect. Details in #28534.

For storage, I think the situation might be a bit analogous to azure-sdk-for-net storage dir:

@jsquire
Copy link
Member

jsquire commented Feb 3, 2023

@jsquire if I enable the new regex-based wildcard-supporting CODEOWNERS matcher the build failure notifications recipients will change, like so (from LEFT OWNERS to RIGHT OWNERS):

I'd reach out to @joshfree, as I don't have the same depth of knowledge for owners in the Java repository as I do for .NET.

@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 8, 2023
Merged
@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit aa72084 into main Feb 8, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/fix_co_2_2_2023 branch February 8, 2023 04:44
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konrad-jamrozik @jsquire @weshaggard