Support passwordless connections for JMS ServiceBus in Spring #33489

backwind1233 · 2023-02-14T02:56:30Z

Description

Linked issue: #32463

The PR is an implementation to support passwordless connections for JMS ServiceBus in Spring.

Test locally

Test Redis Passwordless ✅
Test Jdbc-MySQL Passwordless ✅
Test Jdbc-Postgre Passwordless ✅
Test JMS Passwordless ✅
Test Kafka Passwordless ✅

IT

pipeline: java - spring - tests ✅
pipeline: java - spring - tests-weekly ✅

azure-sdk · 2023-02-14T03:16:43Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure
spring-cloud-azure-core
spring-cloud-azure-service

backwind1233 · 2023-02-14T08:20:16Z

/azp run java - spring - tests

azure-pipelines · 2023-02-14T08:20:31Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-02-14T09:38:00Z

The resource scopes in ServiceBus is the same for different Clouds: "https://servicebus.azure.net/.default".

saragluna · 2023-02-15T01:45:19Z

...rc/main/java/com/azure/spring/cloud/autoconfigure/jms/AzureServiceBusCredentialSupplier.java

+ *
+ * @since 4.7.0
+ */
+public class AzureServiceBusCredentialSupplier implements Supplier<String> {


Suggested change

public class AzureServiceBusCredentialSupplier implements Supplier<String> {

public class AzureServiceBusJmsCredentialSupplier implements Supplier<String> {

?

saragluna · 2023-02-15T01:52:46Z

...ain/java/com/azure/spring/cloud/autoconfigure/jms/ServiceBusJmsConnectionFactoryFactory.java

-            String remoteUrl = String.format(AMQP_URI_FORMAT, host, properties.getIdleTimeout().toMillis());
-            String username = serviceBusConnectionString.getSharedAccessKeyName();
-            String password = serviceBusConnectionString.getSharedAccessKey();
+            String remoteUrl = null;


The ServiceBusJmsConnectionFactory shouldn't need to understand the serviceBusPasswordlessProperties

I have refactored the code, I provided a ServiceConnectionStringProvider, but it's a little strange for me now. Maybe we can discuss about it.

ServiceConnectionStringProvider is not the best choice.

saragluna · 2023-02-15T01:54:29Z

...ava/com/azure/spring/cloud/integration/tests/servicebus/jms/ServiceBusJmsPasswordlessIT.java

+@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)
+@ActiveProfiles("servicebus-jms-passwordless")
+public class ServiceBusJmsPasswordlessIT {
+    private static final Logger LOGGER = LoggerFactory.getLogger(ServiceBusJmsPasswordlessIT.class);
+    private static final String DATA = "service bus jms passwordless test";
+    private static final String QUEUE_NAME = "que001";
+    private final Exchanger<String> EXCHANGER = new Exchanger<>();
+
+    @Autowired
+    private JmsTemplate jmsTemplate;
+
+    @Test
+    @Timeout(70)
+    public void testServiceBusJmsOperation() throws InterruptedException {
+        LOGGER.info("ServiceBusJmsPasswordlessIT begin.");
+        jmsTemplate.convertAndSend(QUEUE_NAME, DATA);
+        LOGGER.info("Send message: {}", DATA);
+        String msg = EXCHANGER.exchange(null);
+        Assertions.assertEquals(DATA, msg);
+        LOGGER.info("ServiceBusJmsPasswordlessIT end.");
+    }
+
+    @JmsListener(destination = QUEUE_NAME, containerFactory = "jmsListenerContainerFactory")
+    public void receiveQueueMessage(String message) throws InterruptedException {
+        LOGGER.info("Received message from queue: {}", message);
+        EXCHANGER.exchange(message);
+    }
+}


No need of the public

backwind1233 · 2023-02-15T03:30:34Z

/azp run java - spring - tests

azure-pipelines · 2023-02-15T03:30:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-02-28T07:34:34Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-03-01T06:23:59Z

/azp run java - spring - tests

azure-pipelines · 2023-03-01T06:24:13Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-03-02T01:37:16Z

/azp run java - spring - tests

azure-pipelines · 2023-03-02T01:37:29Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-03-02T04:13:09Z

/azp run java - spring - tests

azure-pipelines · 2023-03-02T04:13:23Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-03-02T08:01:27Z

/azp run java - spring - tests

azure-pipelines · 2023-03-02T08:01:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-03-02T08:01:46Z

No pipelines are associated with this pull request.

azure-pipelines · 2023-03-02T08:14:54Z

No pipelines are associated with this pull request.

backwind1233 · 2023-03-02T08:56:17Z

/azp run java - spring - tests-weekly

azure-pipelines · 2023-03-02T08:56:25Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2023-03-02T09:47:42Z

pipeline: java - spring - tests ✅
pipeline: java - spring - tests-weekly ✅

...azure/spring/cloud/autoconfigure/passwordless/AzurePasswordlessEnvironmentPostProcessor.java

...oconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/passwordless/package-info.java

…33489) Support passwordless connections for JMS ServiceBus in Spring.

* Support passwordless connections for JMS ServiceBus in Spring (#33489) * fix differences in two versions --------- Co-authored-by: zhihaoguo <zhihaoguo@microsoft.com>

jms passwordless

d957828

ghost added the azure-spring All azure-spring related issues label Feb 14, 2023

backwind1233 self-assigned this Feb 14, 2023

backwind1233 added 2 commits February 14, 2023 16:00

use namespace instead of endpoint

3a4737e

address some pipeline errors

9888266

backwind1233 added 3 commits February 14, 2023 17:29

code refactor

be9940c

update identity

df12f2e

Merge branch 'main' into passwordless_jms

16f7168

backwind1233 changed the title ~~Support JMS ServiceBus passwordless connections~~ Support passwordless connections for JMS ServiceBus in Spring Feb 14, 2023

backwind1233 marked this pull request as ready for review February 14, 2023 09:36

backwind1233 requested review from mssfang, JonathanGiles, chenrujun, hui1110, Netyyyy, saragluna, stliu, yiliuTo, moarychan and fangjian0423 as code owners February 14, 2023 09:36

saragluna requested changes Feb 15, 2023

View reviewed changes

backwind1233 added 2 commits February 15, 2023 09:58

use && not &

374d95f

address comments

68069c6

fix ut errors

3776c56

backwind1233 force-pushed the passwordless_jms branch from 34366bd to 61ee897 Compare March 1, 2023 06:23

backwind1233 added 2 commits March 1, 2023 14:52

add test case for AzurePasswordlessPropertiesUtils

d915384

update java doc

99a1c5d

backwind1233 added 4 commits March 2, 2023 09:40

use ArrayList

115ec19

fix jms bug

ed2386d

Merge branch 'main' into passwordless_jms

fbd531b

update azure-sdk-bom version

64bd4a3

fix bug of ServiceBusJmsPasswordlessIT

ae1bce7

saragluna requested changes Mar 3, 2023

View reviewed changes

...azure/spring/cloud/autoconfigure/passwordless/AzurePasswordlessEnvironmentPostProcessor.java Outdated Show resolved Hide resolved

...oconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/passwordless/package-info.java Outdated Show resolved Hide resolved

address some comments

97a6480

saragluna approved these changes Mar 3, 2023

View reviewed changes

add some java docs

db2691e

backwind1233 merged commit 0aa7f47 into Azure:main Mar 3, 2023

saragluna pushed a commit to saragluna/azure-sdk-for-java that referenced this pull request Jun 26, 2023

Support passwordless connections for JMS ServiceBus in Spring (Azure#…

3c7f328

…33489) Support passwordless connections for JMS ServiceBus in Spring.

saragluna mentioned this pull request Jun 26, 2023

Port #33489 jms passwordless to spring boot 3 branch #35608

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support passwordless connections for JMS ServiceBus in Spring #33489

Support passwordless connections for JMS ServiceBus in Spring #33489

backwind1233 commented Feb 14, 2023 •

edited

Loading

azure-sdk commented Feb 14, 2023 •

edited

Loading

backwind1233 commented Feb 14, 2023

azure-pipelines bot commented Feb 14, 2023

backwind1233 commented Feb 14, 2023

saragluna Feb 15, 2023

saragluna Feb 15, 2023

backwind1233 Feb 15, 2023 •

edited

Loading

saragluna Feb 16, 2023

saragluna Feb 15, 2023

backwind1233 commented Feb 15, 2023

azure-pipelines bot commented Feb 15, 2023

azure-pipelines bot commented Feb 28, 2023

backwind1233 commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

	public class AzureServiceBusCredentialSupplier implements Supplier<String> {
	public class AzureServiceBusJmsCredentialSupplier implements Supplier<String> {

Support passwordless connections for JMS ServiceBus in Spring #33489

Support passwordless connections for JMS ServiceBus in Spring #33489

Conversation

backwind1233 commented Feb 14, 2023 • edited Loading

Description

Test locally

IT

azure-sdk commented Feb 14, 2023 • edited Loading

backwind1233 commented Feb 14, 2023

azure-pipelines bot commented Feb 14, 2023

backwind1233 commented Feb 14, 2023

saragluna Feb 15, 2023

Choose a reason for hiding this comment

saragluna Feb 15, 2023

Choose a reason for hiding this comment

backwind1233 Feb 15, 2023 • edited Loading

Choose a reason for hiding this comment

saragluna Feb 16, 2023

Choose a reason for hiding this comment

saragluna Feb 15, 2023

Choose a reason for hiding this comment

backwind1233 commented Feb 15, 2023

azure-pipelines bot commented Feb 15, 2023

azure-pipelines bot commented Feb 28, 2023

backwind1233 commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

azure-pipelines bot commented Mar 2, 2023

backwind1233 commented Mar 2, 2023

backwind1233 commented Feb 14, 2023 •

edited

Loading

azure-sdk commented Feb 14, 2023 •

edited

Loading

backwind1233 Feb 15, 2023 •

edited

Loading