Client Encryption: Adds fix to allow partition key path and id to be part of client encryption policy. #33648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayush3011
requested review from
alzimmermsft,
samvaity,
g2vinay,
JimSuplizio,
srnagar,
JonathanGiles,
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
simorenoh,
jeet1995 and
Pilchie
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…b.com:aayush3011/azure-sdk-for-java into users/akataria/AddEncryptionIdAndPartitionKey
…b.com:aayush3011/azure-sdk-for-java into users/akataria/AddEncryptionIdAndPartitionKey
| return Mono.just(itemId); | ||
| } | ||
|
|
||
| private Mono<PartitionKey> checkAndGetEncryptedPartitionKey(PartitionKey partitionKey, EncryptionSettings encryptionSettings) { |
There was a problem hiding this comment.
Please add dedicated unit tests for this method going through PartitonKey NULL/EMPTY/null as well as single and hierarchical partition keys with dedicated encryption and because parent node is part of the encryption policy.
There was a problem hiding this comment.
I have already added partition key tests for null/empty and single pk. I don't have test cases for the hierarchical pks. I will add those and update this comment.
There was a problem hiding this comment.
@aayush3011 Is this done?
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Show resolved
Hide resolved
...encryption/src/main/java/com/azure/cosmos/encryption/implementation/EncryptionProcessor.java
Outdated
Show resolved
Hide resolved
...-encryption/src/main/java/com/azure/cosmos/encryption/models/SqlQuerySpecWithEncryption.java
Outdated
Show resolved
Hide resolved
...-encryption/src/main/java/com/azure/cosmos/encryption/models/SqlQuerySpecWithEncryption.java
Show resolved
Hide resolved
FabianMeiswinkel
previously requested changes
Mar 20, 2023
…b.com:aayush3011/azure-sdk-for-java into users/akataria/AddEncryptionIdAndPartitionKey
…b.com:aayush3011/azure-sdk-for-java into users/akataria/AddEncryptionIdAndPartitionKey
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
requested changes
Apr 12, 2023
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Show resolved
Hide resolved
| return Mono.just(itemId); | ||
| } | ||
|
|
||
| private Mono<PartitionKey> checkAndGetEncryptedPartitionKey(PartitionKey partitionKey, EncryptionSettings encryptionSettings) { |
There was a problem hiding this comment.
@aayush3011 Is this done?
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Show resolved
Hide resolved
...-encryption/src/main/java/com/azure/cosmos/encryption/models/SqlQuerySpecWithEncryption.java
Show resolved
Hide resolved
…b.com:aayush3011/azure-sdk-for-java into users/akataria/AddEncryptionIdAndPartitionKey
kushagraThapar
approved these changes
Apr 13, 2023
kushagraThapar
dismissed
FabianMeiswinkel’s stale review
Comments have been resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
.Net PRs:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines